From 41cfe20aeb9835315c54b3d6873d4e07ff238cfa Mon Sep 17 00:00:00 2001
From: yeg <1347747024@qq.com>
Date: 星期六, 29 八月 2026 18:15:46 +0800
Subject: [PATCH] 实现测试必填设备绑定
---
ruoyi-admin/src/test/java/com/ruoyi/system/service/impl/TTestServiceImplTest.java | 155 ++++++++++++++++++++++++++++++++++++++++++++++-----
1 files changed, 138 insertions(+), 17 deletions(-)
diff --git a/ruoyi-admin/src/test/java/com/ruoyi/system/service/impl/TTestServiceImplTest.java b/ruoyi-admin/src/test/java/com/ruoyi/system/service/impl/TTestServiceImplTest.java
index 75541e4..5793f3e 100644
--- a/ruoyi-admin/src/test/java/com/ruoyi/system/service/impl/TTestServiceImplTest.java
+++ b/ruoyi-admin/src/test/java/com/ruoyi/system/service/impl/TTestServiceImplTest.java
@@ -10,6 +10,7 @@
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
+import static org.mockito.Mockito.times;
import java.math.BigDecimal;
import java.util.Collections;
@@ -21,11 +22,16 @@
import org.mockito.junit.jupiter.MockitoExtension;
import com.ruoyi.common.exception.ServiceException;
import com.ruoyi.system.domain.TTest;
+import com.ruoyi.system.domain.TBatteryGroup;
+import com.ruoyi.system.domain.TBatteryGroupRelationField;
import com.ruoyi.system.domain.TTestBattery;
import com.ruoyi.system.domain.TTestChannelBinding;
+import com.ruoyi.system.domain.TTestCollectorChannel;
+import com.ruoyi.system.domain.TTestFieldSnapshot;
import com.ruoyi.system.domain.TTestPlanStep;
import com.ruoyi.system.domain.TTestWarningThreshold;
import com.ruoyi.system.mapper.TTestMapper;
+import com.ruoyi.system.service.ITBatteryGroupService;
/** 测试配置服务的业务契约测试。 */
@ExtendWith(MockitoExtension.class)
@@ -33,6 +39,9 @@
{
@Mock
private TTestMapper testMapper;
+
+ @Mock
+ private ITBatteryGroupService batteryGroupService;
@InjectMocks
private TTestServiceImpl testService;
@@ -42,6 +51,7 @@
{
TTest test = validTest();
mockEnabledOptions();
+ mockGroupSnapshot();
when(testMapper.insertTest(any(TTest.class))).thenAnswer(invocation -> {
invocation.<TTest>getArgument(0).setTestId(10L);
return 1;
@@ -53,34 +63,42 @@
assertEquals(10L, testService.createTest(test));
assertEquals("WAITING", test.getTestStatus());
- assertEquals("NOT_MONITORED", test.getMonitoringStatus());
+ assertEquals("NOT_STARTED", test.getReceptionStatus());
assertEquals(7L, test.getCreatorId());
verify(testMapper).insertTestPlanStep(any(TTestPlanStep.class));
verify(testMapper).insertTestChannelBinding(any(TTestChannelBinding.class));
+ verify(testMapper, times(3)).insertTestCollectorChannel(any(TTestCollectorChannel.class));
+ verify(testMapper).insertTestFieldSnapshot(any());
verify(testMapper).insertTestThreshold(any(TTestWarningThreshold.class));
verify(testMapper).insertTestAudit(anyLong(), any(), anyLong(), any(), isNull(), any());
}
@Test
- void createShouldAllowMissingCollector()
+ void createShouldRejectMissingCollector()
{
TTest test = validTest();
test.getBatteries().get(0).setCollectorId(null);
mockEnabledPeopleAndType();
when(testMapper.countBatteryInEnabledGroup(1L, "BAT-001")).thenReturn(1);
when(testMapper.countRegisteredChannel(100L)).thenReturn(1);
- when(testMapper.insertTest(any(TTest.class))).thenAnswer(invocation -> {
- invocation.<TTest>getArgument(0).setTestId(10L);
- return 1;
- });
- doAnswer(invocation -> {
- invocation.<TTestBattery>getArgument(0).setRelationId(20L);
- return 1;
- }).when(testMapper).insertTestBattery(any(TTestBattery.class));
- assertEquals(10L, testService.createTest(test));
+ ServiceException exception = assertThrows(ServiceException.class, () -> testService.createTest(test));
- verify(testMapper, never()).countCollectorEnabled(anyLong());
+ assertEquals("采集器不能为空", exception.getMessage());
+ verify(testMapper, never()).insertTest(any(TTest.class));
+ }
+
+ @Test
+ void createShouldRejectMissingRequiredCollectorChannel()
+ {
+ TTest test = validTest();
+ test.getBatteries().get(0).getCollectorChannels().remove(0);
+ mockEnabledOptions();
+
+ ServiceException exception = assertThrows(ServiceException.class, () -> testService.createTest(test));
+
+ assertEquals("每个电池号必须绑定主温度、正电位主通道和负电位主通道", exception.getMessage());
+ verify(testMapper, never()).insertTest(any(TTest.class));
}
@Test
@@ -89,6 +107,7 @@
TTest test = validTest();
test.setPlanSteps(Collections.emptyList());
mockEnabledOptions();
+ mockGroupSnapshot();
when(testMapper.insertTest(any(TTest.class))).thenAnswer(invocation -> {
invocation.<TTest>getArgument(0).setTestId(10L);
return 1;
@@ -152,10 +171,31 @@
when(testMapper.countBatteryInEnabledGroup(1L, "BAT-002")).thenReturn(1);
when(testMapper.countRegisteredChannel(100L)).thenReturn(1);
when(testMapper.countCollectorEnabled(8L)).thenReturn(1);
+ when(testMapper.selectCollectorChannelCount(8L)).thenReturn(4);
ServiceException exception = assertThrows(ServiceException.class, () -> testService.createTest(test));
assertEquals("同一检测柜通道不可重复绑定", exception.getMessage());
+ verify(testMapper, never()).insertTest(any(TTest.class));
+ }
+
+ @Test
+ void createShouldRejectDuplicateCollectorChannelMapping()
+ {
+ TTest test = validTest();
+ TTestBattery second = validBattery("BAT-002", 2L, 101L);
+ test.setBatteries(java.util.List.of(test.getBatteries().get(0), second));
+ mockEnabledPeopleAndType();
+ when(testMapper.countBatteryInEnabledGroup(1L, "BAT-001")).thenReturn(1);
+ when(testMapper.countBatteryInEnabledGroup(1L, "BAT-002")).thenReturn(1);
+ when(testMapper.countRegisteredChannel(100L)).thenReturn(1);
+ when(testMapper.countRegisteredChannel(101L)).thenReturn(1);
+ when(testMapper.countCollectorEnabled(8L)).thenReturn(1);
+ when(testMapper.selectCollectorChannelCount(8L)).thenReturn(4);
+
+ ServiceException exception = assertThrows(ServiceException.class, () -> testService.createTest(test));
+
+ assertEquals("同一采集器通道不可重复映射", exception.getMessage());
verify(testMapper, never()).insertTest(any(TTest.class));
}
@@ -170,6 +210,7 @@
when(testMapper.countBatteryInEnabledGroup(1L, "BAT-001")).thenReturn(1);
when(testMapper.countRegisteredChannel(100L)).thenReturn(1);
when(testMapper.countCollectorEnabled(8L)).thenReturn(1);
+ when(testMapper.selectCollectorChannelCount(8L)).thenReturn(4);
ServiceException exception = assertThrows(ServiceException.class, () -> testService.createTest(test));
@@ -178,19 +219,36 @@
}
@Test
- void updateShouldRejectConfigurationAfterMonitoringStarted()
+ void updateShouldRejectConfigurationAfterReceptionStarted()
{
TTest request = validTest();
request.setTestId(10L);
TTest current = validTest();
current.setTestId(10L);
- current.setMonitoringStatus("MONITORING");
+ current.setReceptionStatus("RECEIVING");
when(testMapper.selectTestByIdForUpdate(10L)).thenReturn(current);
ServiceException exception = assertThrows(ServiceException.class, () -> testService.updateTest(request));
- assertEquals("开始监测后不能修改测试配置", exception.getMessage());
+ assertEquals("开始接收后不能修改测试配置", exception.getMessage());
verify(testMapper, never()).updateTest(any(TTest.class));
+ }
+
+ @Test
+ void createShouldRejectCollectorChannelOutsideRegisteredRange()
+ {
+ TTest test = validTest();
+ test.getBatteries().get(0).getCollectorChannels().get(2).setChannelCode("S-05");
+ mockEnabledPeopleAndType();
+ when(testMapper.countBatteryInEnabledGroup(1L, "BAT-001")).thenReturn(1);
+ when(testMapper.countRegisteredChannel(100L)).thenReturn(1);
+ when(testMapper.countCollectorEnabled(8L)).thenReturn(1);
+ when(testMapper.selectCollectorChannelCount(8L)).thenReturn(4);
+
+ ServiceException exception = assertThrows(ServiceException.class, () -> testService.createTest(test));
+
+ assertEquals("采集器通道不存在或超出登记范围", exception.getMessage());
+ verify(testMapper, never()).insertTest(any(TTest.class));
}
@Test
@@ -202,10 +260,11 @@
TTest current = validTest();
current.setTestId(10L);
current.setCreatorId(7L);
- current.setMonitoringStatus("NOT_MONITORED");
+ current.setReceptionStatus("NOT_STARTED");
current.setMonitorTimeoutMinutes(30);
when(testMapper.selectTestByIdForUpdate(10L)).thenReturn(current);
mockEnabledOptions();
+ mockGroupSnapshot();
when(testMapper.updateTest(request)).thenReturn(1);
doAnswer(invocation -> {
invocation.<TTestBattery>getArgument(0).setRelationId(21L);
@@ -220,11 +279,46 @@
}
@Test
+ void updateSameGroupShouldPreserveOriginalFieldSnapshot()
+ {
+ TTest request = validTest();
+ request.setTestId(10L);
+ TTest current = validTest();
+ current.setTestId(10L);
+ current.setCreatorId(7L);
+ current.setReceptionStatus("NOT_STARTED");
+ TTestFieldSnapshot originalSnapshot = new TTestFieldSnapshot();
+ originalSnapshot.setFieldDefinitionId(11L);
+ originalSnapshot.setFieldName("额定容量");
+ originalSnapshot.setFieldType("number");
+ originalSnapshot.setFieldValue("72");
+
+ when(testMapper.selectTestByIdForUpdate(10L)).thenReturn(current);
+ when(testMapper.selectTestBatteries(10L)).thenReturn(current.getBatteries());
+ when(testMapper.selectTestFieldSnapshots(10L)).thenReturn(java.util.List.of(originalSnapshot));
+ mockEnabledOptions();
+ when(testMapper.updateTest(request)).thenReturn(1);
+ doAnswer(invocation -> {
+ invocation.<TTestBattery>getArgument(0).setRelationId(21L);
+ return 1;
+ }).when(testMapper).insertTestBattery(any(TTestBattery.class));
+
+ assertEquals(1, testService.updateTest(request));
+
+ verify(testMapper).insertTestFieldSnapshot(org.mockito.ArgumentMatchers.argThat(snapshot ->
+ Long.valueOf(11L).equals(snapshot.getFieldDefinitionId())
+ && "额定容量".equals(snapshot.getFieldName())
+ && "number".equals(snapshot.getFieldType())
+ && "72".equals(snapshot.getFieldValue())));
+ verify(batteryGroupService, never()).selectBatteryGroupById(anyLong());
+ }
+
+ @Test
void deleteBeforeMonitoringShouldAppendAudit()
{
TTest current = validTest();
current.setTestId(10L);
- current.setMonitoringStatus("NOT_MONITORED");
+ current.setReceptionStatus("NOT_STARTED");
when(testMapper.selectTestByIdForUpdate(10L)).thenReturn(current);
when(testMapper.deleteTestById(10L, "operator")).thenReturn(1);
@@ -239,6 +333,7 @@
when(testMapper.countBatteryInEnabledGroup(1L, "BAT-001")).thenReturn(1);
when(testMapper.countRegisteredChannel(100L)).thenReturn(1);
when(testMapper.countCollectorEnabled(8L)).thenReturn(1);
+ when(testMapper.selectCollectorChannelCount(8L)).thenReturn(4);
}
private void mockEnabledPeopleAndType()
@@ -246,6 +341,19 @@
when(testMapper.countUserEnabled(7L)).thenReturn(1);
when(testMapper.countUserEnabled(9L)).thenReturn(1);
when(testMapper.countTestTypeEnabled(3L)).thenReturn(1);
+ }
+
+ private void mockGroupSnapshot()
+ {
+ TBatteryGroupRelationField field = new TBatteryGroupRelationField();
+ field.setBatteryGroupFieldId(11L);
+ field.setFieldName("额定容量");
+ field.setFieldType("number");
+ field.setFieldValue("72");
+ TBatteryGroup group = new TBatteryGroup();
+ group.setGroupId(1L);
+ group.setTemplateFields(java.util.List.of(field));
+ when(batteryGroupService.selectBatteryGroupById(1L)).thenReturn(group);
}
private TTest validTest()
@@ -295,7 +403,20 @@
battery.setBatteryNo(batteryNo);
battery.setCollectorId(8L);
battery.setBinding(binding);
+ battery.setCollectorChannels(new java.util.ArrayList<>(java.util.List.of(
+ collectorChannel("PRIMARY_TEMPERATURE", "主温度", "S-01"),
+ collectorChannel("PRIMARY_POSITIVE_POTENTIAL", "正电位主通道", "S-02"),
+ collectorChannel("PRIMARY_NEGATIVE_POTENTIAL", "负电位主通道", "S-03"))));
battery.setFields(Collections.emptyList());
return battery;
}
+
+ private TTestCollectorChannel collectorChannel(String measurementCode, String measurementName, String channelCode)
+ {
+ TTestCollectorChannel mapping = new TTestCollectorChannel();
+ mapping.setMeasurementCode(measurementCode);
+ mapping.setMeasurementName(measurementName);
+ mapping.setChannelCode(channelCode);
+ return mapping;
+ }
}
--
Gitblit v1.7.1