From 2ba6d57e221fda12c8198444324cfa517dc3d5dc Mon Sep 17 00:00:00 2001
From: mitao <2763622819@qq.com>
Date: 星期三, 17 九月 2025 14:36:57 +0800
Subject: [PATCH] 将创建待办事项抽取为公共方法
---
ruoyi-system/src/main/java/com/ruoyi/system/service/impl/OaApprovalApplicationPurchaseServiceImpl.java | 133 ------------------
ruoyi-system/src/main/java/com/ruoyi/system/service/impl/OaApprovalApplicationStorageServiceImpl.java | 127 +-----------------
ruoyi-system/src/main/java/com/ruoyi/system/service/impl/OaApprovalTodoServiceImpl.java | 142 ++++++++++++++++++++
ruoyi-system/src/main/java/com/ruoyi/system/service/OaApprovalTodoService.java | 11 +
4 files changed, 161 insertions(+), 252 deletions(-)
diff --git a/ruoyi-system/src/main/java/com/ruoyi/system/service/OaApprovalTodoService.java b/ruoyi-system/src/main/java/com/ruoyi/system/service/OaApprovalTodoService.java
index a30c303..5b7f46d 100644
--- a/ruoyi-system/src/main/java/com/ruoyi/system/service/OaApprovalTodoService.java
+++ b/ruoyi-system/src/main/java/com/ruoyi/system/service/OaApprovalTodoService.java
@@ -1,6 +1,7 @@
package com.ruoyi.system.service;
import com.baomidou.mybatisplus.extension.service.IService;
+import com.ruoyi.system.model.OaApprovalFlowNode;
import com.ruoyi.system.model.OaApprovalTodo;
/**
@@ -12,5 +13,13 @@
* @since 2025-09-15
*/
public interface OaApprovalTodoService extends IService<OaApprovalTodo> {
-
+ /**
+ * 根据流程节点与部门信息，创建对应审批待办
+ *
+ * @param applicationId 申请主表ID
+ * @param applicationCode 申请单号
+ * @param flowNode 当前流程节点配置
+ * @param deptId 申请部门ID（用于上级部门审批场景）
+ */
+ void createApprovalTodos(Integer applicationId, String applicationCode, OaApprovalFlowNode flowNode, Integer deptId);
}
diff --git a/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/OaApprovalApplicationPurchaseServiceImpl.java b/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/OaApprovalApplicationPurchaseServiceImpl.java
index 7d16f94..7d928d4 100644
--- a/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/OaApprovalApplicationPurchaseServiceImpl.java
+++ b/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/OaApprovalApplicationPurchaseServiceImpl.java
@@ -1,9 +1,6 @@
package com.ruoyi.system.service.impl;
-import cn.hutool.core.collection.CollUtil;
import com.baomidou.mybatisplus.extension.service.impl.ServiceImpl;
-import com.ruoyi.common.core.domain.entity.SysDept;
-import com.ruoyi.common.core.domain.entity.SysUser;
import com.ruoyi.common.exception.ServiceException;
import com.ruoyi.system.dto.asset.OaApprovalApplicationPurchaseDTO;
import com.ruoyi.system.emums.ApprovalStatusEnum;
@@ -12,7 +9,6 @@
import com.ruoyi.system.model.OaApprovalApplicationPurchaseItem;
import com.ruoyi.system.model.OaApprovalApplications;
import com.ruoyi.system.model.OaApprovalFlowNode;
-import com.ruoyi.system.model.OaApprovalTodo;
import com.ruoyi.system.service.ISysDeptService;
import com.ruoyi.system.service.ISysUserService;
import com.ruoyi.system.service.OaApprovalApplicationPurchaseItemService;
@@ -21,17 +17,13 @@
import com.ruoyi.system.service.OaApprovalFlowNodeService;
import com.ruoyi.system.service.OaApprovalTodoService;
import lombok.RequiredArgsConstructor;
-import org.apache.commons.lang3.StringUtils;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;
import org.springframework.util.CollectionUtils;
import java.time.LocalDate;
-import java.time.LocalDateTime;
import java.time.format.DateTimeFormatter;
-import java.util.Arrays;
import java.util.List;
-import java.util.stream.Collectors;
/**
* <p>
@@ -63,8 +55,8 @@
applications.setCurrentFlowNodeId(firstFlowNode.getId());
oaApprovalApplicationsService.save(applications);
- // 3.创建待办事项记录
- createApprovalTodo(applications.getId(), applications.getApplicationCode(), firstFlowNode, dto.getDeptId());
+ // 3. 创建待办事项记录（公共服务）
+ oaApprovalTodoService.createApprovalTodos(applications.getId(), applications.getApplicationCode(), firstFlowNode, dto.getDeptId());
// 4.保存采购资产明细数据
List<OaApprovalApplicationPurchaseItem> items = buildOaApprovalApplicationPurchaseItems(dto, applications.getId());
@@ -93,127 +85,6 @@
return flowNodes.get(0);
}
- /**
- * 创建待办数据
- */
- private void createApprovalTodo(Integer applicationId, String applicationCode, OaApprovalFlowNode flowNode, Integer deptId) {
- // 根据审批类型创建待办数据
- Integer approvalType = flowNode.getApprovalType();
- if (approvalType == null) {
- throw new ServiceException("审批类型不能为空");
- }
-
- switch (approvalType) {
- case 0: // 上级部门审批
- createUpperDeptTodo(applicationId, applicationCode, flowNode, deptId);
- break;
- case 1: // 指定部门审批
- createSpecifiedDeptTodo(applicationId, applicationCode, flowNode);
- break;
- case 2: // 指定人员审批
- createSpecifiedUserTodo(applicationId, applicationCode, flowNode);
- break;
- default:
- throw new ServiceException("不支持的审批类型: " + approvalType);
- }
- }
- /**
- * 创建上级部门审批待办
- */
- private void createUpperDeptTodo(Integer applicationId, String applicationCode, OaApprovalFlowNode flowNode, Integer deptId) {
- // 1. 获取申请部门信息
- if (deptId == null) {
- throw new ServiceException("未填写申请部门信息");
- }
-
- SysDept currentDept = sysDeptService.selectDeptById(Long.valueOf(deptId));
- if (currentDept == null) {
- throw new ServiceException("申请部门信息不存在");
- }
-
- // 2. 获取上级部门信息
- if (currentDept.getParentId() == null || currentDept.getParentId() == 0) {
- throw new ServiceException("当前部门没有上级部门");
- }
-
- SysDept parentDept = sysDeptService.selectDeptById(currentDept.getParentId());
- if (parentDept == null) {
- throw new ServiceException("上级部门信息不存在");
- }
-
- // 3. 查询所有关联了该上级部门的用户
- List<SysUser> users = sysUserService.selectListByDeptId(parentDept.getDeptId().toString());
- if (CollUtil.isEmpty(users)) {
- throw new ServiceException("上级部门下没有找到用户");
- }
-
- // 4. 为每个用户创建待办数据
- createTodoItem(applicationId, applicationCode, flowNode, users);
- }
-
- /**
- * 创建指定部门审批待办
- */
- private void createSpecifiedDeptTodo(Integer applicationId, String applicationCode, OaApprovalFlowNode flowNode) {
- if (StringUtils.isBlank(flowNode.getApprovalIds())) {
- throw new ServiceException("操作失败，审批流程配置异常");
- }
- // 收集部门ID
- List<String> deptIdList = Arrays.stream(flowNode.getApprovalIds().split(",")).collect(Collectors.toList());
-
- // 查询所有关联了这些部门的用户
- List<SysUser> users = sysUserService.selectListByDeptIds(deptIdList);
- if (CollUtil.isEmpty(users)) {
- throw new ServiceException("指定部门下没有找到用户");
- }
-
- // 为每个用户创建待办数据
- createTodoItem(applicationId, applicationCode, flowNode, users);
- }
-
- /**
- * 创建指定人员审批待办
- */
- private void createSpecifiedUserTodo(Integer applicationId, String applicationCode, OaApprovalFlowNode flowNode) {
- if (StringUtils.isBlank(flowNode.getApprovalIds())) {
- throw new ServiceException("操作失败，审批流程配置异常");
- }
- List<Integer> userIds = Arrays.stream(flowNode.getApprovalIds().split(","))
- .map(Integer::valueOf).collect(Collectors.toList());
- // 1. 查询用户信息
- List<SysUser> users = sysUserService.selectListByUserIds(userIds);
- if (CollUtil.isEmpty(users)) {
- throw new ServiceException("没有找到指定审批用户");
- }
- //2. 创建待办数据
- createTodoItem(applicationId, applicationCode, flowNode, users);
- }
-
- /**
- * 创建待办数据项
- */
- private void createTodoItem(Integer applicationId, String applicationCode, OaApprovalFlowNode flowNode, List<SysUser> userList) {
- List<OaApprovalTodo> approvalTodoList = userList.stream().map(item -> {
- OaApprovalTodo todo = new OaApprovalTodo();
- todo.setApplicationId(applicationId);
- todo.setApplicationCode(applicationCode);
- todo.setFlowNodeId(flowNode.getId());
- todo.setUserId(item.getUserId().intValue());
- todo.setUserName(item.getNickName());
-
- // 设置部门信息
- if (item.getDeptId() != null) {
- todo.setDeptId(Integer.valueOf(item.getDeptId()));
- }
-
- todo.setSortOrder(flowNode.getSortOrder());
- todo.setStatus(0); // 0-待处理
- todo.setCreateTime(LocalDateTime.now());
- return todo;
- }).collect(Collectors.toList());
- //批量保存
- oaApprovalTodoService.saveBatch(approvalTodoList);
- }
/**
* 构建审批申请主表数据
*/
diff --git a/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/OaApprovalApplicationStorageServiceImpl.java b/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/OaApprovalApplicationStorageServiceImpl.java
index 1e91e6b..a043153 100644
--- a/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/OaApprovalApplicationStorageServiceImpl.java
+++ b/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/OaApprovalApplicationStorageServiceImpl.java
@@ -63,8 +63,8 @@
applications.setCurrentFlowNodeId(firstFlowNode.getId());
oaApprovalApplicationsService.save(applications);
- // 3. 创建待办事项记录
- createApprovalTodo(applications.getId(), applications.getApplicationCode(), firstFlowNode, dto.getDeptId());
+ // 3. 创建待办事项记录（公共服务）
+ oaApprovalTodoService.createApprovalTodos(applications.getId(), applications.getApplicationCode(), firstFlowNode, dto.getDeptId());
// 4. 保存资产入库申请明细数据
OaApprovalApplicationStorage storage = buildOaApprovalApplicationStorage(dto, applications.getId());
@@ -85,8 +85,8 @@
applications.setCurrentFlowNodeId(firstFlowNode.getId());
oaApprovalApplicationsService.save(applications);
- // 3. 创建待办事项记录
- createApprovalTodo(applications.getId(), applications.getApplicationCode(), firstFlowNode, dto.getDeptId());
+ // 3. 创建待办事项记录（公共服务）
+ oaApprovalTodoService.createApprovalTodos(applications.getId(), applications.getApplicationCode(), firstFlowNode, dto.getDeptId());
// 4. 保存资产入库申请明细数据
OaApprovalApplicationStorage storage = buildOaApprovalApplicationStorage(dto, applications.getId());
@@ -107,8 +107,8 @@
applications.setCurrentFlowNodeId(firstFlowNode.getId());
oaApprovalApplicationsService.save(applications);
- // 3. 创建待办事项记录
- createApprovalTodo(applications.getId(), applications.getApplicationCode(), firstFlowNode, dto.getDeptId());
+ // 3. 创建待办事项记录（公共服务）
+ oaApprovalTodoService.createApprovalTodos(applications.getId(), applications.getApplicationCode(), firstFlowNode, dto.getDeptId());
// 4. 保存资产入库申请明细数据
OaApprovalApplicationStorage storage = buildOaApprovalApplicationStorage(dto, applications.getId());
@@ -400,119 +400,6 @@
return flowNodes.get(0);
}
- /**
- * 创建待办数据
- */
- private void createApprovalTodo(Integer applicationId, String applicationCode, OaApprovalFlowNode flowNode, Integer deptId) {
- Integer approvalType = flowNode.getApprovalType();
- if (approvalType == null) {
- throw new ServiceException("审批类型不能为空");
- }
-
- switch (approvalType) {
- case 0:
- createUpperDeptTodo(applicationId, applicationCode, flowNode, deptId);
- break;
- case 1:
- createSpecifiedDeptTodo(applicationId, applicationCode, flowNode);
- break;
- case 2:
- createSpecifiedUserTodo(applicationId, applicationCode, flowNode);
- break;
- default:
- throw new ServiceException("不支持的审批类型: " + approvalType);
- }
- }
-
- /**
- * 创建上级部门审批待办
- */
- private void createUpperDeptTodo(Integer applicationId, String applicationCode, OaApprovalFlowNode flowNode, Integer deptId) {
- if (deptId == null) {
- throw new ServiceException("未填写申请部门信息");
- }
-
- SysDept currentDept = sysDeptService.selectDeptById(Long.valueOf(deptId));
- if (currentDept == null) {
- throw new ServiceException("申请部门信息不存在");
- }
-
- if (currentDept.getParentId() == null || currentDept.getParentId() == 0) {
- throw new ServiceException("当前部门没有上级部门");
- }
-
- SysDept parentDept = sysDeptService.selectDeptById(currentDept.getParentId());
- if (parentDept == null) {
- throw new ServiceException("上级部门信息不存在");
- }
-
- List<SysUser> users = sysUserService.selectListByDeptId(parentDept.getDeptId().toString());
- if (CollUtil.isEmpty(users)) {
- throw new ServiceException("上级部门下没有找到用户");
- }
-
- createTodoItem(applicationId, applicationCode, flowNode, users);
- }
-
- /**
- * 创建指定部门审批待办
- */
- private void createSpecifiedDeptTodo(Integer applicationId, String applicationCode, OaApprovalFlowNode flowNode) {
- if (StringUtils.isBlank(flowNode.getApprovalIds())) {
- throw new ServiceException("操作失败，审批流程配置异常");
- }
-
- List<String> deptIdList = Arrays.stream(flowNode.getApprovalIds().split(",")).collect(Collectors.toList());
- List<SysUser> users = sysUserService.selectListByDeptIds(deptIdList);
- if (CollUtil.isEmpty(users)) {
- throw new ServiceException("指定部门下没有找到用户");
- }
-
- createTodoItem(applicationId, applicationCode, flowNode, users);
- }
-
- /**
- * 创建指定人员审批待办
- */
- private void createSpecifiedUserTodo(Integer applicationId, String applicationCode, OaApprovalFlowNode flowNode) {
- if (StringUtils.isBlank(flowNode.getApprovalIds())) {
- throw new ServiceException("操作失败，审批流程配置异常");
- }
-
- List<Integer> userIds = Arrays.stream(flowNode.getApprovalIds().split(","))
- .map(Integer::valueOf).collect(Collectors.toList());
- List<SysUser> users = sysUserService.selectListByUserIds(userIds);
- if (CollUtil.isEmpty(users)) {
- throw new ServiceException("没有找到指定审批用户");
- }
-
- createTodoItem(applicationId, applicationCode, flowNode, users);
- }
-
- /**
- * 创建待办数据项
- */
- private void createTodoItem(Integer applicationId, String applicationCode, OaApprovalFlowNode flowNode, List<SysUser> userList) {
- List<OaApprovalTodo> approvalTodoList = userList.stream().map(item -> {
- OaApprovalTodo todo = new OaApprovalTodo();
- todo.setApplicationId(applicationId);
- todo.setApplicationCode(applicationCode);
- todo.setFlowNodeId(flowNode.getId());
- todo.setUserId(item.getUserId().intValue());
- todo.setUserName(item.getNickName());
-
- if (item.getDeptId() != null) {
- todo.setDeptId(Integer.valueOf(item.getDeptId()));
- }
-
- todo.setSortOrder(flowNode.getSortOrder());
- todo.setStatus(0);
- todo.setCreateTime(LocalDateTime.now());
- return todo;
- }).collect(Collectors.toList());
-
- oaApprovalTodoService.saveBatch(approvalTodoList);
- }
/**
* 构建审批申请主表数据
@@ -630,4 +517,4 @@
return prefix + sequenceStr;
}
-}
\ No newline at end of file
+}
diff --git a/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/OaApprovalTodoServiceImpl.java b/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/OaApprovalTodoServiceImpl.java
index 8b40616..503c9d6 100644
--- a/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/OaApprovalTodoServiceImpl.java
+++ b/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/OaApprovalTodoServiceImpl.java
@@ -1,10 +1,25 @@
package com.ruoyi.system.service.impl;
+import cn.hutool.core.collection.CollUtil;
import com.baomidou.mybatisplus.extension.service.impl.ServiceImpl;
+import com.ruoyi.common.core.domain.entity.SysDept;
+import com.ruoyi.common.core.domain.entity.SysUser;
+import com.ruoyi.common.exception.ServiceException;
import com.ruoyi.system.mapper.OaApprovalTodoMapper;
+import com.ruoyi.system.model.OaApprovalFlowNode;
import com.ruoyi.system.model.OaApprovalTodo;
+import com.ruoyi.system.service.ISysDeptService;
+import com.ruoyi.system.service.ISysUserService;
import com.ruoyi.system.service.OaApprovalTodoService;
+import lombok.RequiredArgsConstructor;
+import org.apache.commons.lang3.StringUtils;
import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
+
+import java.time.LocalDateTime;
+import java.util.Arrays;
+import java.util.List;
+import java.util.stream.Collectors;
/**
* <p>
@@ -15,6 +30,133 @@
* @since 2025-09-15
*/
@Service
+@RequiredArgsConstructor
public class OaApprovalTodoServiceImpl extends ServiceImpl<OaApprovalTodoMapper, OaApprovalTodo> implements OaApprovalTodoService {
+ private final ISysUserService sysUserService;
+ private final ISysDeptService sysDeptService;
+
+ /**
+ * 创建审批待办（公共实现）
+ */
+ @Override
+ @Transactional(rollbackFor = Exception.class)
+ public void createApprovalTodos(Integer applicationId, String applicationCode, OaApprovalFlowNode flowNode, Integer deptId) {
+ Integer approvalType = flowNode.getApprovalType();
+ if (approvalType == null) {
+ throw new ServiceException("审批类型不能为空");
+ }
+
+ switch (approvalType) {
+ case 0: // 上级部门审批
+ createUpperDeptTodo(applicationId, applicationCode, flowNode, deptId);
+ break;
+ case 1: // 指定部门审批
+ createSpecifiedDeptTodo(applicationId, applicationCode, flowNode);
+ break;
+ case 2: // 指定人员审批
+ createSpecifiedUserTodo(applicationId, applicationCode, flowNode);
+ break;
+ default:
+ throw new ServiceException("不支持的审批类型: " + approvalType);
+ }
+ }
+
+ /**
+ * 创建上级部门审批待办
+ */
+ private void createUpperDeptTodo(Integer applicationId, String applicationCode, OaApprovalFlowNode flowNode, Integer deptId) {
+ // 1. 获取申请部门信息
+ if (deptId == null) {
+ throw new ServiceException("未填写申请部门信息");
+ }
+
+ SysDept currentDept = sysDeptService.selectDeptById(Long.valueOf(deptId));
+ if (currentDept == null) {
+ throw new ServiceException("申请部门信息不存在");
+ }
+
+ // 2. 获取上级部门信息
+ if (currentDept.getParentId() == null || currentDept.getParentId() == 0) {
+ throw new ServiceException("当前部门没有上级部门");
+ }
+
+ SysDept parentDept = sysDeptService.selectDeptById(currentDept.getParentId());
+ if (parentDept == null) {
+ throw new ServiceException("上级部门信息不存在");
+ }
+
+ // 3. 查询所有关联了该上级部门的用户
+ List<SysUser> users = sysUserService.selectListByDeptId(parentDept.getDeptId().toString());
+ if (CollUtil.isEmpty(users)) {
+ throw new ServiceException("上级部门下没有找到用户");
+ }
+
+ // 4. 为每个用户创建待办数据
+ createTodoItem(applicationId, applicationCode, flowNode, users);
+ }
+
+ /**
+ * 创建指定部门审批待办
+ */
+ private void createSpecifiedDeptTodo(Integer applicationId, String applicationCode, OaApprovalFlowNode flowNode) {
+ if (StringUtils.isBlank(flowNode.getApprovalIds())) {
+ throw new ServiceException("操作失败，审批流程配置异常");
+ }
+ // 收集部门ID
+ List<String> deptIdList = Arrays.stream(flowNode.getApprovalIds().split(",")).collect(Collectors.toList());
+
+ // 查询所有关联了这些部门的用户
+ List<SysUser> users = sysUserService.selectListByDeptIds(deptIdList);
+ if (CollUtil.isEmpty(users)) {
+ throw new ServiceException("指定部门下没有找到用户");
+ }
+
+ // 为每个用户创建待办数据
+ createTodoItem(applicationId, applicationCode, flowNode, users);
+ }
+
+ /**
+ * 创建指定人员审批待办
+ */
+ private void createSpecifiedUserTodo(Integer applicationId, String applicationCode, OaApprovalFlowNode flowNode) {
+ if (StringUtils.isBlank(flowNode.getApprovalIds())) {
+ throw new ServiceException("操作失败，审批流程配置异常");
+ }
+ List<Integer> userIds = Arrays.stream(flowNode.getApprovalIds().split(","))
+ .map(Integer::valueOf).collect(Collectors.toList());
+ // 1. 查询用户信息
+ List<SysUser> users = sysUserService.selectListByUserIds(userIds);
+ if (CollUtil.isEmpty(users)) {
+ throw new ServiceException("没有找到指定审批用户");
+ }
+ //2. 创建待办数据
+ createTodoItem(applicationId, applicationCode, flowNode, users);
+ }
+
+ /**
+ * 创建待办数据项
+ */
+ private void createTodoItem(Integer applicationId, String applicationCode, OaApprovalFlowNode flowNode, List<SysUser> userList) {
+ List<OaApprovalTodo> approvalTodoList = userList.stream().map(item -> {
+ OaApprovalTodo todo = new OaApprovalTodo();
+ todo.setApplicationId(applicationId);
+ todo.setApplicationCode(applicationCode);
+ todo.setFlowNodeId(flowNode.getId());
+ todo.setUserId(item.getUserId().intValue());
+ todo.setUserName(item.getNickName());
+
+ // 设置部门信息
+ if (item.getDeptId() != null) {
+ todo.setDeptId(Integer.valueOf(item.getDeptId()));
+ }
+
+ todo.setSortOrder(flowNode.getSortOrder());
+ todo.setStatus(0); // 0-待处理
+ todo.setCreateTime(LocalDateTime.now());
+ return todo;
+ }).collect(Collectors.toList());
+ //批量保存
+ this.saveBatch(approvalTodoList);
+ }
}
--
Gitblit v1.7.1