From 22a9b4588c8eeefdb9e16fda9125af8c0b846b49 Mon Sep 17 00:00:00 2001
From: Pu Zhibing <393733352@qq.com>
Date: 星期四, 26 九月 2024 18:00:39 +0800
Subject: [PATCH] 修改bug

---
 ruoyi-auth/src/main/java/com/ruoyi/auth/service/SysLoginService.java |  222 ++++++++++++++++++++++++++-----------------------------
 1 files changed, 104 insertions(+), 118 deletions(-)

diff --git a/ruoyi-auth/src/main/java/com/ruoyi/auth/service/SysLoginService.java b/ruoyi-auth/src/main/java/com/ruoyi/auth/service/SysLoginService.java
index 3223a6b..c443059 100644
--- a/ruoyi-auth/src/main/java/com/ruoyi/auth/service/SysLoginService.java
+++ b/ruoyi-auth/src/main/java/com/ruoyi/auth/service/SysLoginService.java
@@ -22,125 +22,111 @@
 
 /**
  * 登录校验方法
- * 
+ *
  * @author ruoyi
  */
 @Component
-public class SysLoginService
-{
-    @Autowired
-    private RemoteUserService remoteUserService;
-
-    @Autowired
-    private SysPasswordService passwordService;
-
-    @Autowired
-    private SysRecordLogService recordLogService;
-
-    @Autowired
-    private RedisService redisService;
-
-    /**
-     * 登录
-     */
-    public LoginUser login(String username, String password, HttpServletRequest request) {
-        // 查询用户信息
-        R<LoginUser> userResult = remoteUserService.getUserInfo(username, SecurityConstants.INNER);
-    
-        if (StringUtils.isNull(userResult) || StringUtils.isNull(userResult.getData()))
-        {
-            recordLogService.recordLogininfor(request, null, username, Constants.LOGIN_FAIL_STATUS, "登录用户不存在");
-            throw new ServiceException("登录用户:" + username + " 不存在");
-        }
-        LoginUser userInfo = userResult.getData();
-        SysUser user = userResult.getData().getSysUser();
-        
-        // 用户名或密码为空 错误
-        if (StringUtils.isAnyBlank(username, password))
-        {
-            recordLogService.recordLogininfor(request, user.getUserId().intValue(), username, Constants.LOGIN_FAIL_STATUS, "用户/密码必须填写");
-            throw new ServiceException("用户/密码必须填写");
-        }
-        // 密码如果不在指定范围内 错误
-        if (password.length() < UserConstants.PASSWORD_MIN_LENGTH
-                || password.length() > UserConstants.PASSWORD_MAX_LENGTH)
-        {
-            recordLogService.recordLogininfor(request, user.getUserId().intValue(), username, Constants.LOGIN_FAIL_STATUS, "用户密码不在指定范围");
-            throw new ServiceException("用户密码不在指定范围");
-        }
-        // 用户名不在指定范围内 错误
-        if (username.length() < UserConstants.USERNAME_MIN_LENGTH
-                || username.length() > UserConstants.USERNAME_MAX_LENGTH)
-        {
-            recordLogService.recordLogininfor(request, user.getUserId().intValue(), username, Constants.LOGIN_FAIL_STATUS, "用户名不在指定范围");
-            throw new ServiceException("用户名不在指定范围");
-        }
-        // IP黑名单校验
-        String blackStr = Convert.toStr(redisService.getCacheObject(CacheConstants.SYS_LOGIN_BLACKIPLIST));
-        if (IpUtils.isMatchedIp(blackStr, IpUtils.getIpAddr()))
-        {
-            recordLogService.recordLogininfor(request, user.getUserId().intValue(), username, Constants.LOGIN_FAIL_STATUS, "很遗憾,访问IP已被列入系统黑名单");
-            throw new ServiceException("很遗憾,访问IP已被列入系统黑名单");
-        }
-
-        if (R.FAIL == userResult.getCode())
-        {
-            throw new ServiceException(userResult.getMsg());
-        }
-        
-        
-        if (UserStatus.DELETED.getCode().equals(user.getDelFlag()))
-        {
-            recordLogService.recordLogininfor(request, user.getUserId().intValue(), username, Constants.LOGIN_FAIL_STATUS, "对不起,您的账号已被删除");
-            throw new ServiceException("对不起,您的账号:" + username + " 已被删除");
-        }
-        if (UserStatus.DISABLE.getCode().equals(user.getStatus()))
-        {
-            recordLogService.recordLogininfor(request, user.getUserId().intValue(), username, Constants.LOGIN_FAIL_STATUS, "用户已停用,请联系管理员");
-            throw new ServiceException("对不起,您的账号:" + username + " 已停用");
-        }
-        passwordService.validate(user, password, request);
-        recordLogService.recordLogininfor(request, user.getUserId().intValue(), username, Constants.LOGIN_SUCCESS_STATUS, "登录成功");
-        return userInfo;
-    }
-
-    public void logout(String loginName, HttpServletRequest request)
-    {
-        recordLogService.recordLogininfor(request, null, loginName, Constants.LOGIN_SUCCESS_STATUS, "退出成功");
-    }
-
-    /**
-     * 注册
-     */
-    public void register(String username, String password, HttpServletRequest request)
-    {
-        // 用户名或密码为空 错误
-        if (StringUtils.isAnyBlank(username, password))
-        {
-            throw new ServiceException("用户/密码必须填写");
-        }
-        if (username.length() < UserConstants.USERNAME_MIN_LENGTH
-                || username.length() > UserConstants.USERNAME_MAX_LENGTH)
-        {
-            throw new ServiceException("账户长度必须在2到20个字符之间");
-        }
-        if (password.length() < UserConstants.PASSWORD_MIN_LENGTH
-                || password.length() > UserConstants.PASSWORD_MAX_LENGTH)
-        {
-            throw new ServiceException("密码长度必须在5到20个字符之间");
-        }
-
-        // 注册用户信息
-        SysUser sysUser = new SysUser();
-        sysUser.setUserName(username);
-        sysUser.setNickName(username);
-        sysUser.setPassword(SecurityUtils.encryptPassword(password));
-        R<?> registerResult = remoteUserService.registerUserInfo(sysUser, SecurityConstants.INNER);
-
-        if (R.FAIL == registerResult.getCode())
-        {
-            throw new ServiceException(registerResult.getMsg());
-        }
-        recordLogService.recordLogininfor(request, sysUser.getUserId().intValue(), username, Constants.LOGIN_SUCCESS_STATUS, "注册成功");
-    }
+public class SysLoginService {
+	@Autowired
+	private RemoteUserService remoteUserService;
+	
+	@Autowired
+	private SysPasswordService passwordService;
+	
+	@Autowired
+	private SysRecordLogService recordLogService;
+	
+	@Autowired
+	private RedisService redisService;
+	
+	/**
+	 * 登录
+	 */
+	public LoginUser login(String username, String password, HttpServletRequest request) {
+		username = username.trim();
+		// 查询用户信息
+		R<LoginUser> userResult = remoteUserService.getUserInfo(username, SecurityConstants.INNER);
+		
+		if (StringUtils.isNull(userResult) || StringUtils.isNull(userResult.getData())) {
+			recordLogService.recordLogininfor(request, null, username, Constants.LOGIN_FAIL_STATUS, "登录用户不存在");
+			throw new ServiceException("登录用户:" + username + " 不存在");
+		}
+		LoginUser userInfo = userResult.getData();
+		SysUser user = userResult.getData().getSysUser();
+		
+		// 用户名或密码为空 错误
+		if (StringUtils.isAnyBlank(username, password)) {
+			recordLogService.recordLogininfor(request, user.getUserId().intValue(), username, Constants.LOGIN_FAIL_STATUS, "用户/密码必须填写");
+			throw new ServiceException("用户/密码必须填写");
+		}
+		// 密码如果不在指定范围内 错误
+		if (password.length() < UserConstants.PASSWORD_MIN_LENGTH
+				|| password.length() > UserConstants.PASSWORD_MAX_LENGTH) {
+			recordLogService.recordLogininfor(request, user.getUserId().intValue(), username, Constants.LOGIN_FAIL_STATUS, "用户密码不在指定范围");
+			throw new ServiceException("用户密码不在指定范围");
+		}
+		// 用户名不在指定范围内 错误
+		if (username.length() < UserConstants.USERNAME_MIN_LENGTH
+				|| username.length() > UserConstants.USERNAME_MAX_LENGTH) {
+			recordLogService.recordLogininfor(request, user.getUserId().intValue(), username, Constants.LOGIN_FAIL_STATUS, "用户名不在指定范围");
+			throw new ServiceException("用户名不在指定范围");
+		}
+		// IP黑名单校验
+		String blackStr = Convert.toStr(redisService.getCacheObject(CacheConstants.SYS_LOGIN_BLACKIPLIST));
+		if (IpUtils.isMatchedIp(blackStr, IpUtils.getIpAddr())) {
+			recordLogService.recordLogininfor(request, user.getUserId().intValue(), username, Constants.LOGIN_FAIL_STATUS, "很遗憾,访问IP已被列入系统黑名单");
+			throw new ServiceException("很遗憾,访问IP已被列入系统黑名单");
+		}
+		
+		if (R.FAIL == userResult.getCode()) {
+			throw new ServiceException(userResult.getMsg());
+		}
+		
+		
+		if (UserStatus.DELETED.getCode().equals(user.getDelFlag())) {
+			recordLogService.recordLogininfor(request, user.getUserId().intValue(), username, Constants.LOGIN_FAIL_STATUS, "对不起,您的账号已被删除");
+			throw new ServiceException("对不起,您的账号:" + username + " 已被删除");
+		}
+		if (UserStatus.DISABLE.getCode().equals(user.getStatus())) {
+			recordLogService.recordLogininfor(request, user.getUserId().intValue(), username, Constants.LOGIN_FAIL_STATUS, "用户已停用,请联系管理员");
+			throw new ServiceException("对不起,您的账号:" + username + " 已停用");
+		}
+		passwordService.validate(user, password, request);
+		recordLogService.recordLogininfor(request, user.getUserId().intValue(), username, Constants.LOGIN_SUCCESS_STATUS, "登录成功");
+		return userInfo;
+	}
+	
+	public void logout(String loginName, HttpServletRequest request) {
+		recordLogService.recordLogininfor(request, null, loginName, Constants.LOGIN_SUCCESS_STATUS, "退出成功");
+	}
+	
+	/**
+	 * 注册
+	 */
+	public void register(String username, String password, HttpServletRequest request) {
+		// 用户名或密码为空 错误
+		if (StringUtils.isAnyBlank(username, password)) {
+			throw new ServiceException("用户/密码必须填写");
+		}
+		if (username.length() < UserConstants.USERNAME_MIN_LENGTH
+				|| username.length() > UserConstants.USERNAME_MAX_LENGTH) {
+			throw new ServiceException("账户长度必须在2到20个字符之间");
+		}
+		if (password.length() < UserConstants.PASSWORD_MIN_LENGTH
+				|| password.length() > UserConstants.PASSWORD_MAX_LENGTH) {
+			throw new ServiceException("密码长度必须在5到20个字符之间");
+		}
+		
+		// 注册用户信息
+		SysUser sysUser = new SysUser();
+		sysUser.setUserName(username);
+		sysUser.setNickName(username);
+		sysUser.setPassword(SecurityUtils.encryptPassword(password));
+		R<?> registerResult = remoteUserService.registerUserInfo(sysUser, SecurityConstants.INNER);
+		
+		if (R.FAIL == registerResult.getCode()) {
+			throw new ServiceException(registerResult.getMsg());
+		}
+		recordLogService.recordLogininfor(request, sysUser.getUserId().intValue(), username, Constants.LOGIN_SUCCESS_STATUS, "注册成功");
+	}
 }

--
Gitblit v1.7.1