From c980c8c2cd9403393db6a3f42705612a0a4d4511 Mon Sep 17 00:00:00 2001
From: Pu Zhibing <393733352@qq.com>
Date: 星期一, 16 十二月 2024 15:49:04 +0800
Subject: [PATCH] Merge remote-tracking branch 'origin/master'

---
 ruoyi-service/ruoyi-account/src/main/java/com/ruoyi/account/controller/VipCenterController.java |   59 ++++++++++++++++++++++++++---------------------------------
 1 files changed, 26 insertions(+), 33 deletions(-)

diff --git a/ruoyi-service/ruoyi-account/src/main/java/com/ruoyi/account/controller/VipCenterController.java b/ruoyi-service/ruoyi-account/src/main/java/com/ruoyi/account/controller/VipCenterController.java
index 7c21768..04feab8 100644
--- a/ruoyi-service/ruoyi-account/src/main/java/com/ruoyi/account/controller/VipCenterController.java
+++ b/ruoyi-service/ruoyi-account/src/main/java/com/ruoyi/account/controller/VipCenterController.java
@@ -6,12 +6,11 @@
 import com.ruoyi.account.vo.vip.Level;
 import com.ruoyi.account.vo.vip.VipLevel;
 import com.ruoyi.common.core.domain.R;
+import com.ruoyi.common.core.exception.ServiceException;
 import com.ruoyi.common.core.utils.bean.BeanUtils;
 import com.ruoyi.common.security.service.TokenService;
 import com.ruoyi.other.api.domain.*;
-import com.ruoyi.other.api.feignClient.BaseSettingClient;
-import com.ruoyi.other.api.feignClient.GoodsVipClient;
-import com.ruoyi.other.api.feignClient.RemoteVipSettingClient;
+import com.ruoyi.other.api.feignClient.*;
 import io.swagger.annotations.Api;
 import io.swagger.annotations.ApiOperation;
 import io.swagger.annotations.ApiParam;
@@ -42,6 +41,10 @@
     private TokenService tokenService;
     @Resource
     private VipCenterService vipCenterService;
+    @Resource
+    private VipGoodClient vipGoodClient;
+    @Resource
+    private GoodsClient goodsClient;
 
 
     @GetMapping("getVipLevelList")
@@ -49,7 +52,7 @@
     public R<VipLevel> vipLevelList() {
         try {
             R<List<VipSetting>> r = remoteVipSettingClient.list();
-            if (checkSuccess(r)) {
+            if (R.isError(r)) {
                 return R.fail("会员等级获取失败");
             }
             List<VipSetting> vipSettingList = r.getData();
@@ -58,7 +61,7 @@
             }
 
             R<BaseSetting> baseSettingR = baseSettingClient.getBaseSetting(3);
-            if (checkSuccess(baseSettingR)) {
+            if (R.isError(baseSettingR)) {
                 log.error("【会员设置说明】获取失败:{}", baseSettingR.getMsg());
                 return R.fail("会员等级获取失败");
             }
@@ -76,7 +79,6 @@
 
             // 批量获取 goodsVip 和 vipGoods
             List<Integer> vipIds = vipSettingList.stream().map(VipSetting::getId).collect(Collectors.toList());
-            Map<Integer, R<GoodsVip>> goodsVipMap = getGoodsVips(vipIds);
             Map<Integer, R<List<VipGood>>> vipGoodsMap = getVipGoods(vipIds);
 
             vipSettingList.forEach(vipSetting -> {
@@ -84,25 +86,23 @@
                 BeanUtils.copyBeanProp(level, vipSetting);
                 level.setVipDesc(baseSetting.getContent());
 
-                R<GoodsVip> goodsVipR = goodsVipMap.get(vipSetting.getId());
-                if (R.isSuccess(goodsVipR)) {
-                    R<List<VipGood>> vipGoodR = vipGoodsMap.get(vipSetting.getId());
-                    if (R.isSuccess(vipGoodR)) {
-                        List<VipGood> vipGoodList = vipGoodR.getData();
-                        if (vipGoodList != null && !vipGoodList.isEmpty()) {
-                            List<String> goodsNames = new ArrayList<>();
-                            vipGoodList.forEach(vipGood -> {
-                                String goodJson = vipGood.getGoodJson();
-                                if (isValidJson(goodJson)) {
-                                    Goods goods = JSONObject.parseObject(goodJson, Goods.class);
-                                    goodsNames.add(goods.getName());
-                                } else {
-                                    log.warn("JSON无效: " + goodJson);
-                                }
-                            });
-                            level.setGoodsNames(goodsNames);
+                R<List<VipGood>> vipGoodR = vipGoodsMap.get(vipSetting.getId());
+                if (R.isError(vipGoodR)) {
+                    throw new ServiceException("会员商品获取失败");
+                }
+                List<VipGood> vipGoodList = vipGoodR.getData();
+                if (vipGoodList != null && !vipGoodList.isEmpty()) {
+                    List<String> goodsNames = new ArrayList<>();
+                    vipGoodList.forEach(vipGood -> {
+                        Integer goodId = vipGood.getGoodId();
+                        R<Goods> goodsR = goodsClient.getGoodsById(goodId);
+                        if (R.isError(goodsR)) {
+                         throw new ServiceException("商品信息获取失败");
                         }
-                    }
+                        Goods goods = goodsR.getData();
+                        goodsNames.add(goods.getName());
+                    });
+                    level.setGoodsNames(goodsNames);
                 }
                 levelList.add(level);
             });
@@ -127,13 +127,6 @@
 
 
 
-    private boolean checkSuccess(R<?> r) {
-        if (!R.isSuccess(r)) {
-            log.error("请求失败: " + r.getMsg());
-        }
-        return R.isSuccess(r);
-    }
-
     private Map<Integer, R<GoodsVip>> getGoodsVips(List<Integer> vipIds) {
         Map<Integer, R<GoodsVip>> result = new HashMap<>();
         for (Integer vipId : vipIds) {
@@ -146,8 +139,8 @@
     private Map<Integer, R<List<VipGood>>> getVipGoods(List<Integer> vipIds) {
         Map<Integer, R<List<VipGood>>> result = new HashMap<>();
         for (Integer vipId : vipIds) {
-//            R<List<VipGood>> vipGoodR = vipGoodClient.getVipGoodsByVipId(vipId);
-//            result.put(vipId, vipGoodR);
+            R<List<VipGood>> vipGoodR = vipGoodClient.getVipGoodsByVipId(vipId);
+            result.put(vipId, vipGoodR);
         }
         return result;
     }

--
Gitblit v1.7.1